-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit-Tree Rebuild #21
Draft
forgottosave
wants to merge
10
commits into
main
Choose a base branch
from
topic-commit_tree_rebuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgottosave
added
state: 👷🏻 in development
Currently worked on
✨ feature
New feature or request
labels
Oct 17, 2024
This was
linked to
issues
Oct 17, 2024
forgottosave
force-pushed
the
topic-commit_tree_rebuild
branch
from
October 21, 2024 14:42
98b1f51
to
6f7c2bf
Compare
forgottosave
force-pushed
the
topic-commit_tree_rebuild
branch
from
October 21, 2024 14:47
6f7c2bf
to
cb514e8
Compare
debatable if it should be in util instead, but could be changed later if wanted
forgottosave
force-pushed
the
topic-commit_tree_rebuild
branch
from
October 21, 2024 16:25
cb514e8
to
1e2c598
Compare
This is still WIP and should only show what a snappy window could look like. Still A LOT of code duplication from the original window implementation and should be changed to inheritance or something
Reusing the old commit tree for demo purposes. There are heavy changes to be made, if drag-and-drop onto branches should be supported.
replaced by CommitComponent, as its complexity porbably won't allow for any reuse as a general snappy-window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bigger rebuild of the commit-tree part of the
ostree-tui
, to support drag-and-drop functionality of commits for intuitive commit promotion & deletion. It also would solve #17, and partially #14, if during promotion the according confirmation window contains the modifiable strings.Detailed prototype images & descriptions might follow soon.
Features
p
&→/←
for promotion & branch selectiond
for deletionWork to do
cpplibostree
sticky window
s fromftxui::window
to snap back after letting go & order them in a liststicky window
s