Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to set the speed for AA #102

Open
goodroach opened this issue Oct 25, 2022 · 4 comments
Open

Add a way to set the speed for AA #102

goodroach opened this issue Oct 25, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@goodroach
Copy link
Contributor

This is simple, add a config option that allows us to set a multiplier for the AA. This should be simple as changing a few lines of code in the AA director class. Default value would be 1.0

@TylerS1066
Copy link
Collaborator

I feel like this is probably outside the scope of this plugin, is there a specific reason you want to adjust the speed?

@goodroach
Copy link
Contributor Author

The reason why I want the speed to be increased for all fireballs is because some crafts can catch up to them easily and it creates this strange issue where the fireballs light fires inside the craft especially while it's moving.

@TylerS1066
Copy link
Collaborator

Eh sure, as long as it's completely contained within it's own class and doesn't require NMS this doesn't hurt the plugin.

@TylerS1066 TylerS1066 added the enhancement New feature or request label Oct 26, 2023
@TylerS1066 TylerS1066 moved this from New to Ready for Work in Issue Triage Oct 26, 2023
@TylerS1066
Copy link
Collaborator

After thinking on it, this would be beneficial. Adding it to FireballLivespan.java is probably the easiest thing,

Intybyte added a commit to Intybyte/Movecraft-Combat-fixes that referenced this issue Jul 31, 2024
TylerS1066 added a commit that referenced this issue Aug 10, 2024
* Add #102 + Small refactor

* Fix `AADirectors#adjustValue`

* Add comment to FireballSpeed

* Revert Refactor

* Add Speed changer to FireballLifespan (now FireballBehaviour)

* Fix finite issues

---------

Co-authored-by: TylerS1066 <TylerS1066@users.noreply.github.com>
TylerS1066 added a commit that referenced this issue Aug 11, 2024
TylerS1066 added a commit that referenced this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for Work
Development

No branches or pull requests

2 participants