Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Togglable Bleedfix #118

Closed
goodroach opened this issue Oct 23, 2023 · 1 comment
Closed

Togglable Bleedfix #118

goodroach opened this issue Oct 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@goodroach
Copy link
Contributor

Bleedfix is currently baked into durability override and while that is convenient for some, it's troublesome for others because it's two features in one when it could just be an option to toggle it on using a simple config option like 'enableBleedFix: true'
@TylerS1066
Copy link
Collaborator

To clarify, "bleedfix" is the functionality at DurabilityOverride.java line 58-61.

I think an ideal solution would be to move the feature to a separate class from Durability Override and implement the config as you mention.

@TylerS1066 TylerS1066 added the enhancement New feature or request label Oct 26, 2023
@TylerS1066 TylerS1066 moved this to Ready for Work in Issue Triage Oct 26, 2023
Intybyte added a commit to Intybyte/Movecraft-Combat-fixes that referenced this issue Jul 31, 2024
@Intybyte
Add APDevTeam#118 + Small refactor
6a55e8c
@Intybyte Intybyte mentioned this issue Jul 31, 2024
Merged
TylerS1066 pushed a commit that referenced this issue Aug 3, 2024
@Intybyte
Add #118 + Small refactor (#135)
bbda4b2 
* Add #118 + Small refactor

* Change Bleedfix priority to `LOW`
@github-project-automation github-project-automation bot moved this from Ready for Work to Resolved in Issue Triage Sep 14, 2024
TylerS1066 added a commit that referenced this issue Sep 14, 2024
@TylerS1066
Revert "Add #118 + Small refactor (#135)"
ecc8ba3 
This reverts commit bbda4b2.
TylerS1066 added a commit that referenced this issue Sep 14, 2024
@TylerS1066
Revert "Add #118 + Small refactor (#135)" (#140)
d91137d 
This reverts commit bbda4b2.
DerToaster98 added a commit to TTE-DevTeam/Movecraft-Combat-TTE that referenced this issue Nov 24, 2024
@DerToaster98
Merge pull request #2 from APDevTeam/main
1fa5c1c 
Revert "Add APDevTeam#118 + Small refactor (APDevTeam#135)" (APDevTeam#140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Issue Triage
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerS1066 @goodroach