Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incendiary toggle for ExplosionEvent #586

Closed
goodroach opened this issue May 22, 2023 · 4 comments
Closed

Incendiary toggle for ExplosionEvent #586

goodroach opened this issue May 22, 2023 · 4 comments

Comments

@goodroach
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want torpedos and other collision-explosion craft to do some fire damage along with their typical explosion.

Describe the solution you'd like
This is quite simple iirc, as all I need to do is to add a new craft config setting, add a boolean that toggles incendiary effect in ExplosionEvent, and finally add a boolean parameter to the createExplosion() method to allow for an incendiary effect.

@TylerS1066
Copy link
Contributor

Is there a parameter for the amount of fire to use? If so, we should also include that, but I like the idea.

@TylerS1066 TylerS1066 moved this from New to Ready for Work in Issue Triage May 23, 2023
@goodroach
Copy link
Contributor Author

No, unfortunately, it's just a boolean in the createExplosion method. I personally don't think it matters that much but I can just add this feature if you like. Do you have any recommendations on my particular solution?

@TylerS1066
Copy link
Contributor

That should cover it, my one note is to make sure that the incendiary flag is passed to the event so protection addons can work with it.

Intybyte added a commit to Intybyte/Movecraft-fixes that referenced this issue Jul 31, 2024
@Intybyte Intybyte mentioned this issue Jul 31, 2024
1 task
TylerS1066 pushed a commit that referenced this issue Aug 3, 2024
@TylerS1066
Copy link
Contributor

Closed in #677

@github-project-automation github-project-automation bot moved this from Ready for Work to Resolved in Issue Triage Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants