Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on PlayerListener class #631

Closed
SecretX33 opened this issue Mar 30, 2024 · 1 comment · Fixed by #676
Closed

Issue on PlayerListener class #631

SecretX33 opened this issue Mar 30, 2024 · 1 comment · Fixed by #676

Comments

@SecretX33
Copy link

SecretX33 commented Mar 30, 2024

I'm almost sure this line is wrong:

This check is always true since e is an Event and well, events are never a Player. Also, I think this methods wants to listen for PlayerDeathEvent and not EntityDamageByEntityEvent given its name (onPlayerDeath).

@TylerS1066
Copy link
Contributor

That's a good catch and explains why that crafts don't sink when the player is killed.

We should just remove that listener, since it's never worked. If somebody does want the feature, we could re-add it and default it to disabled.

@TylerS1066 TylerS1066 moved this from New to Ready for Work in Issue Triage Mar 30, 2024
Intybyte added a commit to Intybyte/Movecraft-fixes that referenced this issue Jul 30, 2024
@Intybyte Intybyte mentioned this issue Jul 30, 2024
1 task
TylerS1066 pushed a commit that referenced this issue Aug 4, 2024
* Fix #631

* Sink ship instead of release
@github-project-automation github-project-automation bot moved this from Ready for Work to Resolved in Issue Triage Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants