Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block highlights and protocollib #533

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Remove block highlights and protocollib #533

merged 1 commit into from
Jul 30, 2022

Conversation

TylerS1066
Copy link
Contributor

@TylerS1066 TylerS1066 commented Jul 30, 2022

Describe in detail what your pull request accomplishes

Due to a number of reasons, it has been decided that the block highlights feature should be removed. Here is a summary of the reasons why:

  1. ProtocolLib was the only dependency of Movecraft, something we've aimed to eliminate since the 7.0.0 betas.
  2. ProtocolLib has been slow at updating to new Minecraft versions, and still does not have a 1.19 release a month after the update.
  3. The entities can cause a huge amount of client lag.
  4. The code was not cleaned up.

Checklist

  • Tested

@TylerS1066 TylerS1066 marked this pull request as ready for review July 30, 2022 19:33
@TylerS1066 TylerS1066 merged commit 0cf847b into main Jul 30, 2022
@TylerS1066 TylerS1066 deleted the no-highlights branch July 30, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant