Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to run with incompatible NMS #589

Merged

Conversation

TylerS1066
Copy link
Contributor

Describe in detail what your pull request accomplishes

In addition to adding an option to bypass the NMS version check, this also starts de-internationalizing the console messages.

Removing the internationalization of the console messages is twofold:

  1. It reduces the development overhead when writing new console messages.
  2. If a server owner is unable to understand English, it is unlikely they are going to be able to read the wiki to understand our documentation, properly report issues, or converse in discussions.

Related issues:

Checklist

  • Proper internationalization
  • Tested

@TylerS1066 TylerS1066 linked an issue May 27, 2023 that may be closed by this pull request
@TylerS1066 TylerS1066 merged commit a132f39 into main May 29, 2023
@TylerS1066 TylerS1066 deleted the 584-config-option-to-disable-incompatible-nms-version-checks branch May 29, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Option to Disable Incompatible NMS Version Checks
1 participant