Rewrite/translation task #684
Conversation
There was a problem hiding this comment.
While I appreciate the work and improvement to the codebase this PR (and it's twin) brings, I would like to avoid PRs that refactor classes without any performance or feature improvements (especially for classes that will need to be rewritten in the near future).
Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
Outdated
Show resolved
Hide resolved
Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
Outdated
Show resolved
Hide resolved
|
Another note, with the two recent PRs about collision explosions, you should bring that into this PR. |
# Conflicts: # Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
|
Not fully sure why, but torpedos appear to just vanish when testing this. EDIT: It appears that they are either being handled with gravity or max height and fall. |
This was after or before the merge? |
It was using the result of this actions build, triggered from the latest commit in this PR. |
Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
Outdated
Show resolved
Hide resolved
Describe in detail what your pull request accomplishes
Partial rewrite of the class
Checklist