-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tauri Migration from V1 -> V2 and functional android build #9
base: main
Are you sure you want to change the base?
Conversation
If I remember correctly:
Should we migrate to V2 if we support only Desktop at this moment? |
Yes I think we should migrate as from now on this will be the only supported version, and the latest docs will all be for version 2 |
- platform: 'ubuntu-22.04' | ||
args: '' | ||
# TODO: maybe target specifically ARM based macs and Intel based macs to reduce built bundle size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, create a ticket in Asana or GitHub. TODO comments always become stale.
// Android download path | ||
PathBuf::from("/storage/emulated/0/Download/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this fallback folder configurable by the library user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on our discussion here #1 (comment)
I’ve confirmed that the issue still persists on this branch. Here is a video showing how changing just one character in the hash (such as a mistake) disrupts the entire process, with no feedback to the user indicating that the ticket hash is invalid.
FinalistFinal.mp4
A better user experience would be to display a message as soon as the user enters an invalid hash, letting them know it’s not valid.
No description provided.