Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deprecated gradle-build-action to gradle/setup-gradle #80

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tareknaser
Copy link
Collaborator

Description:

This PR updates the deprecated gradle-build-action to the recommended gradle/setup-gradle.

For more details, refer to the deprecation upgrade guide.

Signed-off-by: Tarek <tareknaser360@gmail.com>
@tareknaser tareknaser requested a review from kirillt July 2, 2024 14:26
Copy link

github-actions bot commented Jul 2, 2024

Benchmark for 2379f24

Click to view benchmark
Test Base PR %
blake3_resource_id_creation/compute_from_bytes:large 247.2±1.66µs 248.5±1.32µs +0.53%
blake3_resource_id_creation/compute_from_bytes:medium 15.8±0.04µs 15.7±0.07µs -0.63%
blake3_resource_id_creation/compute_from_bytes:small 1386.6±5.21ns 1390.0±12.31ns +0.25%
blake3_resource_id_creation/compute_from_path:../test-assets/lena.jpg 197.9±1.54µs 197.8±0.30µs -0.05%
blake3_resource_id_creation/compute_from_path:../test-assets/test.pdf 1744.4±10.07µs 1742.9±15.96µs -0.09%
crc32_resource_id_creation/compute_from_bytes:large 86.6±0.37µs 86.8±0.38µs +0.23%
crc32_resource_id_creation/compute_from_bytes:medium 5.4±0.06µs 5.4±0.01µs 0.00%
crc32_resource_id_creation/compute_from_bytes:small 92.4±0.40ns 92.5±1.15ns +0.11%
crc32_resource_id_creation/compute_from_path:../test-assets/lena.jpg 66.3±0.44µs 68.3±0.37µs +3.02%
crc32_resource_id_creation/compute_from_path:../test-assets/test.pdf 970.4±7.74µs 956.6±5.75µs -1.42%
index_build/index_build/../test-assets/ 1070.5±4.24µs 1072.0±4.68µs +0.14%

Copy link
Member

@kirillt kirillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kirillt kirillt merged commit ec2be3e into main Jul 4, 2024
4 checks passed
@tareknaser tareknaser deleted the gradle_ci branch July 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants