Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack sealing for TrustZone context #1037

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kjassmann-renesas
Copy link

@kjassmann-renesas kjassmann-renesas commented Nov 10, 2020

Fixes #1034

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are correct and add a ARMv8-M stack sealing value to each process stack.

@JonatanAntoni
Copy link
Member

@GuentherMartin, I was thinking if we rather should reuse the stack sealing functions we are planning to add into CMSIS-Core. This PR "duplicates" the sealing procedure into the trust zone template. Shall we wait until the functions are available in CMSIS-Core and refactor this patch accordingly?

@ghost
Copy link

ghost commented Nov 11, 2020

@JonatanAntoni, I would suggest to merge the pull request and replace the writing of the stack seal values with the appropriate CMSIS function later. As I see also the file headers in the tz_context.c files need to be adjusted.

@JonatanAntoni
Copy link
Member

@kjassmann-renesas,

We have now #1075 ready for being merged. This patch introduces a stack sealing function (and macros) into CMSIS-Core(M).

Do you think it makes sense to update your PR to use these macros/functions instead of defining it separately?`

Cheers,
Jonatan

@kjassmann-renesas
Copy link
Author

@JonatanAntoni, I agree we should use the new stack sealing function and macro for the seal size. Once that branch is building with IAR I can update this merge request.

@JonatanAntoni
Copy link
Member

@kjassmann-renesas, stack sealing functions have been added for IAR in 0a959c6. May I ask you to crosscheck and update this PR if possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Sealing in CMSIS/Core/Template/ARMv8-M/tz_context.c
2 participants