-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CMSIS Includes #1525
base: develop
Are you sure you want to change the base?
Refactor CMSIS Includes #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific error is fixed.
It's a personal opinion if the changes make the code more readable.
The Changes should cause no harm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific error is fixed.
It's a personal opinion if the changes make the code more readable.
The Changes should cause no harm.
ok to test |
c9155d1
to
1b35075
Compare
I came across redundant
else
statements and someif
statements that can be reworked by Inverting them, in the CMSIS include folder. I believe this will increase the readability and reduce the overall footprint of the code with regards to the amount of lines.Here is a examples one of the many functions that do this.
CMSIS_5/CMSIS/Core/Include/core_cm1.h
Line 669 in e336766
This can be refactored too:
else
statement.if
statement.