-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added macros with bit definitions for Pos/Msk for GICDistributor and GICInterface #1589
Conversation
428bd04
to
894d0de
Compare
@Masmiseim36, does this relate to #1588? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Masmiseim36, could you please tell me against which technical document I should review your changes. I am not experienced with Cortex-A.
I checked "Arm® Generic Interrupt Controller Architecture Specification GIC architecture version 3 and version 4" but the bit definitions in there are a little different.
Hello @JonatanAntoni I do not think that this is related. I haven’t added any definitions for this Register. The implementation for the NVIC peripheral uses a similar solution as @ua1arn has used. I would go with his solution. |
Hello @GuentherMartin I used the ARM CMSIS documentation: |
Hello @Masmiseim36, then I will review you changes against these documents. |
…GICInterface peripheral access structure for Cortex-A
894d0de
to
dd496b9
Compare
…GICInterface (ARM-software#1589) peripheral access structure for Cortex-A
Added macros with bit definitions for Pos/Msk for GICDistributor and GICInterface peripheral access structure for Cortex-A