Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macros with bit definitions for Pos/Msk for GICDistributor and GICInterface #1589

Merged
1 commit merged into from
Nov 22, 2022

Conversation

Masmiseim36
Copy link
Contributor

Added macros with bit definitions for Pos/Msk for GICDistributor and GICInterface peripheral access structure for Cortex-A

@JonatanAntoni
Copy link
Member

@Masmiseim36, does this relate to #1588?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Masmiseim36, could you please tell me against which technical document I should review your changes. I am not experienced with Cortex-A.
I checked "Arm® Generic Interrupt Controller Architecture Specification GIC architecture version 3 and version 4" but the bit definitions in there are a little different.

@Masmiseim36
Copy link
Contributor Author

Masmiseim36 commented Nov 21, 2022

@Masmiseim36, does this relate to #1588?

Hello @JonatanAntoni I do not think that this is related. I haven’t added any definitions for this Register. The implementation for the NVIC peripheral uses a similar solution as @ua1arn has used. I would go with his solution.

@Masmiseim36
Copy link
Contributor Author

Masmiseim36 commented Nov 21, 2022

Hello @Masmiseim36, could you please tell me against which technical document I should review your changes. I am not experienced with Cortex-A. I checked "Arm® Generic Interrupt Controller Architecture Specification GIC architecture version 3 and version 4" but the bit definitions in there are a little different.

Hello @GuentherMartin I used the ARM CMSIS documentation:
https://arm-software.github.io/CMSIS_5/Core_A/html/structGICInterface__Type.html
https://arm-software.github.io/CMSIS_5/Core_A/html/structGICDistributor__Type.html
Should I check any additional resources?
/Edit Cortex A9 Uses GIC version2

@ghost
Copy link

ghost commented Nov 21, 2022

Hello @GuentherMartin I used the ARM CMSIS documentation:
https://arm-software.github.io/CMSIS_5/Core_A/html/structGICInterface__Type.html
https://arm-software.github.io/CMSIS_5/Core_A/html/structGICDistributor__Type.html
Should I check any additional resources?

Hello @Masmiseim36, then I will review you changes against these documents.

@ghost ghost self-requested a review November 21, 2022 12:10
…GICInterface

peripheral access structure for Cortex-A
@ghost ghost merged commit f0cac1c into ARM-software:develop Nov 22, 2022
JiafeiPan pushed a commit to nxp-mcuxpresso/CMSIS_5 that referenced this pull request Aug 8, 2023
…GICInterface (ARM-software#1589)

peripheral access structure for Cortex-A
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants