-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change OS_THREAD_LIBSPACE_NUM to be defined as a (compiler) macro #691
Change OS_THREAD_LIBSPACE_NUM to be defined as a (compiler) macro #691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me as we have those pre-processor guards in all other places as well.
I'd like to question if this guard should only be used in case no object specific memory pools are used. Why not surround the whole block with that guard?
The guard as initially proposed is fine. |
4aa8d15
to
887244c
Compare
@RobertRostohar Just updated revisions, please re-review. |
@JonatanAntoni @RobertRostohar Is there something more you need or is this ready to go in? |
Hi @AnttiKauppila, |
887244c
to
d6d0ce1
Compare
@JonatanAntoni I just updated the PDSC file, ready for merge? |
Hi @AriParkkila, looks good. Thank you very much. Thanks again, |
d6d0ce1
to
eef4305
Compare
OS_THREAD_LIBSPACE_NUM
is defined to 4, which is not a good default in all cases. This change makes it possible to giveOS_THREAD_LIBSPACE_NUM
also as a (compiler) macro.