Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OS_THREAD_LIBSPACE_NUM to be defined as a (compiler) macro #691

Merged

Conversation

AriParkkila
Copy link

OS_THREAD_LIBSPACE_NUM is defined to 4, which is not a good default in all cases. This change makes it possible to give OS_THREAD_LIBSPACE_NUM also as a (compiler) macro.

Copy link
Member

@JonatanAntoni JonatanAntoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me as we have those pre-processor guards in all other places as well.
I'd like to question if this guard should only be used in case no object specific memory pools are used. Why not surround the whole block with that guard?

@RobertRostohar
Copy link
Collaborator

The guard as initially proposed is fine.
However this is a configuration file and therefore versioning needs to be taken into account. Version of the file needs to be changed to 5.5.1 at the top of the file and also in the pack description file (pdsc).

@AriParkkila AriParkkila force-pushed the OS_THREAD_LIBSPACE_NUM branch from 4aa8d15 to 887244c Compare September 27, 2019 09:02
@AriParkkila
Copy link
Author

@RobertRostohar Just updated revisions, please re-review.

@AnttiKauppila
Copy link

@JonatanAntoni @RobertRostohar Is there something more you need or is this ready to go in?

@JonatanAntoni
Copy link
Member

Hi @AnttiKauppila,
sorry for leaving this for couple of weeks. As I stated during review "someone" needs to update all the references to RTX_Config.h (not only the first occurance) in the PDSC file, properly. May I ask you to update your PR accordingly, please?
Thank you again for your contribution,
Jonatan

@AriParkkila AriParkkila force-pushed the OS_THREAD_LIBSPACE_NUM branch from 887244c to d6d0ce1 Compare October 15, 2019 09:54
@AriParkkila
Copy link
Author

@JonatanAntoni I just updated the PDSC file, ready for merge?

@JonatanAntoni
Copy link
Member

Hi @AriParkkila,

looks good. Thank you very much.
May I ask you to rebase your changes to develop, please?

Thanks again,
Jonatan

@AriParkkila AriParkkila force-pushed the OS_THREAD_LIBSPACE_NUM branch from d6d0ce1 to eef4305 Compare October 15, 2019 10:24
@RobertRostohar RobertRostohar merged commit 051d738 into ARM-software:develop Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants