Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Commit

Permalink
mod_power_domain/unit_test: fix compiler error
Browse files Browse the repository at this point in the history
On gcc 13.2.0 the following error is flagged:
error: comparison of integer expressions of different signedness:
‘int’ and ‘enum pd_idx’ [-Werror=sign-compare]

Positive enum should be compared against unsigned variables.

Signed-off-by: Tarek El-Sherbiny <tarek.el-sherbiny@arm.com>
  • Loading branch information
tarek-arm committed Aug 15, 2024
1 parent 2da65a4 commit 5a00810
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ static void init_module_ctx(void)
mod_pd_ctx_temp.system_pd_ctx =
&mod_pd_ctx_temp.pd_ctx_table[PD_IDX_COUNT - 1];

for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
pd_ctx[i] = pd_ctx_config[i];
fwk_list_init(&pd_ctx[i].children_list);
}
}

static void evaluate_valid_state_mask(void)
{
for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int state = 0;
state < pd_ctx[i].allowed_state_mask_table_size;
state++) {
Expand Down Expand Up @@ -439,7 +439,7 @@ void test_is_upwards_transition_propagation_true(void)
pd->cs_support = true;

/* Change the current requested state so a deeper one can be requested */
for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
pd_ctx[i].requested_state = MOD_PD_STATE_ON;
}

Expand Down Expand Up @@ -472,7 +472,7 @@ void test_is_upwards_transition_propagation_no_cs_true(void)
pd->cs_support = false;

/* Swap this round so a deeper state can be requested */
for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
pd_ctx[i].requested_state = MOD_PD_STATE_ON;
}

Expand Down Expand Up @@ -507,7 +507,7 @@ void test_is_allowed_by_parent_and_children_denied(void)
struct pd_ctx *pd = &mod_pd_ctx_temp.pd_ctx_table[PD_IDX_CLUSTER0];

/* Swap this round so a pd can deny it is permitted */
for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
pd_ctx[i].current_state = MOD_PD_STATE_ON;
}

Expand Down
6 changes: 3 additions & 3 deletions module/power_domain/test/mod_power_domain_unit_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ static void init_module_ctx(void)
mod_pd_ctx.pd_count = PD_IDX_COUNT;
mod_pd_ctx.system_pd_ctx = &mod_pd_ctx.pd_ctx_table[PD_IDX_COUNT - 1];

for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
pd_ctx[i] = pd_ctx_config[i];
pd_ctx[i].driver_api = &pd_driver;
fwk_list_init(&pd_ctx[i].children_list);
Expand All @@ -50,7 +50,7 @@ static void init_module_ctx(void)

static void evaluate_valid_state_mask(void)
{
for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int state = 0;
state < pd_ctx[i].allowed_state_mask_table_size;
state++) {
Expand Down Expand Up @@ -812,7 +812,7 @@ void test_process_get_state_request_cs(void)
pd_ctx[PD_IDX_CLUS0CORE0].composite_state_levels_mask = MOD_PD_CS_STATE_MASK
<< MOD_PD_CS_LEVEL_SHIFT;

for (int i = 0; i < PD_IDX_COUNT; ++i) {
for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) {
pd_ctx[i].current_state = MOD_PD_STATE_ON;
}

Expand Down

0 comments on commit 5a00810

Please sign in to comment.