-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for folder attribute in example project environment. #92
Conversation
* Gets the folder attribute stored in the environment tag. | ||
* @return folder in the project, or null of it does not exist. | ||
*/ | ||
String getProjectFolder(String environmentName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interface change: requires default implementation
* Return the folder attribute | ||
* @return folder path, null if not supported. | ||
*/ | ||
String getProjectFolder(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interface change: requires default implementation
com.arm.cmsis.pack/src/com/arm/cmsis/pack/rte/examples/RteExampleItem.java
Show resolved
Hide resolved
return getEnvironmentAttribute(environmentName, CmsisConstants.FOLDER); | ||
} | ||
|
||
private String getEnvironmentAttribute(String environmentName, String attributeName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change visibility to protected and add a comment. CpItem-based classes should be kept open for extension.
Thank you Joakim for the implementation |
The file attribute in the project environment adds the metadata needed to supply compiler specific files in an example project.