Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [logs] resolve problem with the logger source being set for a logr.Logger #479

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

acabarbaye
Copy link
Contributor

Description

  • avoid infinite logger creation loop

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

Copy link
Contributor

@joshjennings98 joshjennings98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks better. I think it makes more sense than having a million sources

@acabarbaye acabarbaye merged commit 678c3e6 into master Aug 14, 2024
6 checks passed
@acabarbaye acabarbaye deleted the loggerfix branch August 14, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants