-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMSIS-DAP v2.1 initial support #870
Conversation
There was a compilation issue that I fixed in [cc36a68]. I also started to add some target information, but as you can imagine it is a very slow process, and this PR should go in as soon as possible. |
Because |
Oops, sorry about the build error. I did a full build, but apparently before I removed the version increments. *sigh* If we make the string functions weak, they'll need to be moved to a .c file. I'll look at it. |
If we make the string functions weak, let's do it in another PR. |
- Merge in v2.1 changes. - Update DAP_config.h for all HICs.
- Add string fields to board and target structs. - Update dap_strings.h functions to return board and target strings when available. - Refactored code in dap_strings.h to use common return_dap_string() utility.
- Targets: AmbiqMicro, Arm, NXP, Maxim, Nordic. - Boards: Ambiq, NXP, Maxim, micro:bit, plus several others.
a226a94
to
c25714b
Compare
I have a question about DAP_PACKET_SIZE definitions which appeared first in this commit. Is it just a copy & paste error, in fact not intended for USB FS devices? |
This change set updates DAPLink to use CMSIS-DAP v2.1. The new
DAP_Info
values are fully supported and can be customised per board and target. Integration of the UART over DAP feature with DAPLink's existing virtual serial interface is not included in this PR and will be added later.These
DAP_Info
values are modified:target_cfg_t::target_vendor
field.target_cfg_t::target_part_number
field.board_info_t::board_vendor
field.board_info_t::board_name
field.Board names have been set for the micro:bit v1 and v2 boards, and target names have been set for all nRF5x targets. These can be used as references
A new documentation file,
string_customization.md
, is added to fully document the above as well as how to configure other user-visible strings.Note that this change corrects the
kTargetConfigVersion
constant that was recently added to be 1, synchronised withkBoardInfoVersion
. Incrementing the struct versions was considered, but given that there are no known existing uses of board and target data being added post-build, we decided to start the version at 1 for the upcoming 0256 release.An additional change that should follow this at some point is to report the values of the target and board names in the
details.txt
file.