Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring - organizing socket info etc #102

Merged
merged 7 commits into from
Oct 10, 2018
Merged

Refactoring - organizing socket info etc #102

merged 7 commits into from
Oct 10, 2018

Conversation

VeijoPesonen
Copy link
Contributor

Description

  • Renames bunch of internal functions and drops superfluous ones along the way
  • Organizes ESP8266Interface's socket info
  • Drops unused member variable ap_sec
  • Fixes layering of network status callbacks
  • Cleans up the mbed_lib.json's help-sections

Pull request type

[] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@VeijoPesonen
Copy link
Contributor Author

@SeppoTakalo @KariHaapalehto please review

@VeijoPesonen VeijoPesonen merged commit 0e890b7 into master Oct 10, 2018
@VeijoPesonen VeijoPesonen deleted the cleanups_n_cosmetic_changes3 branch October 10, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

@KariHaapalehto KariHaapalehto Awaiting requested review from KariHaapalehto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VeijoPesonen @SeppoTakalo