Prevent dead code warning #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
requested changes
Jul 3, 2019
The window size variable in ecp_pick_window_size() can take values 4, 5 or 6, but we clamp it not to exceed the value of MBEDTLS_ECP_WINDOW_SIZE. If that is 6 (default) or higher, the static analyzer will point out that the test: w > MBEDTLS_ECP_WINDOW_SIZE always evaluates to false. This commit removes the test for the cases of the window size large enough to fit all the potential values of the variable.
k-stachowiak
force-pushed
the
IOTCRYPT-474-prevent-dead-code-warning
branch
from
8a28052 to
653a4a2
Compare
gilles-peskine-arm
approved these changes
Jul 4, 2019
Patater
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window size variable in
ecp_pick_window_size()can take values 4, 5 or 6, but we clamp it not to exceed the value ofMBEDTLS_ECP_WINDOW_SIZE. If that is 6 (default) or higher, thestatic analyzer will point out that the test:
w > MBEDTLS_ECP_WINDOW_SIZEalways evaluates to false.This commit removes the test for the cases of the window size large enough to fit all the potential values of the variable.
The issue was found by Coverity and fixed the same way @pkolbus has fixed a similar problem in: Mbed-TLS/mbedtls#2317