Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micro:bit board IDs #277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbrossard
Copy link

Description

Add micro:bit board IDs to platform database.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@MarceloSalazar @Patater

@MarceloSalazar
Copy link

I'm afraid we can't have duplicates in the database.

Board IDs and targets should only be added once the names are confirmed and expected to be publicly released in the future.

@mbrossard
Copy link
Author

I'm afraid we can't have duplicates in the database.

There are precedents (K64F, LPC11U24, LPC1347, LPC4330_M4).

Board IDs and targets should only be added once the names are confirmed and expected to be publicly released in the future.

Support is publicly available: https://github.com/microbit-foundation/mbedos-microbit-v2-starter

CC: @microbit-carlos, @jaustin

@flit
Copy link

flit commented Dec 9, 2021

@MarceloSalazar These are not duplicates, they reflect different board revisions and pop options. micro:bit tools use the different board IDs to automatically provide users with the correct software components.

Having distinct IDs is the only option since there is no other way to encode a board revision in the board ID. (Even CMSIS-DAP v2.1 doesn't add a board revision field to DAP_Info, although I'm proposing this be added.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants