Enable MTS_DRAGONFLY_F411RE to register with Pelion #10287

linlingao · 2019-04-01T19:54:09Z

Description

Enable MTS_DRAGONFLY_F411RE to register with Pelion

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

ciarmcom · 2019-04-01T21:00:30Z

@linlingao, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage please review.

0xc0170 · 2019-04-04T13:18:36Z

Correct NVIC flash vector address for application - DO NOT MERGE YET #10287

Let us know once ready. This looks like some fixes can be sent separately (fixing target code)

linlingao · 2019-04-04T14:12:15Z

@0xc0170 The target code is ready to be merged. Since I needed the SPI changes from @bentcooke, those commits were rolled into this PR. I'm planning to wait for Ben's changes to go in first then rebase.

0xc0170 · 2019-04-04T14:51:45Z

What is the PR number (depending PR here) ?

linlingao · 2019-04-04T15:12:09Z

@0xc0170 #10177

cmonr · 2019-04-08T19:19:25Z

@linlingao Would you happen to know what'll happen with this PR since #10177 was closed?

linlingao · 2019-04-08T20:42:32Z

@cmonr I think @bentcooke will either reopen it or refactor the code in another PR.

linlingao · 2019-04-11T19:52:23Z

@0xc0170 @cmonr This PR is ready to be reviewed/merged.
We have received a new module with a SPIF supporting SFDP. So changes pertinent to no SFDP that were pulled in from PR10177 are no longer needed. I have therefore removed those changes.

cmonr · 2019-04-11T23:52:01Z

@linlingao Mind rebasing?

0xc0170

Looks fine to me ,one clarification for functionality removal.

targets/targets.json

linlingao · 2019-04-12T14:09:28Z

Rebased.

0xc0170 · 2019-04-12T14:14:06Z

Can you rebase instead of merge ? The commit 849b05a is not needed here

linlingao · 2019-04-15T20:04:51Z

@0xc0170 @cmonr I rebased. @bentcooke would like to double check with Mutitech to make sure it's okay to remove their bootloader. Please don't merge yet.

felser · 2019-05-01T13:58:50Z

I built the blinky application for the Dragonfly without adding "target.post_binary_hook:null" to mbed_app.json. The size looks like it includes the bootloader but it's not ours. If ours is included, you can enter it by hitting any key, on the debug port, upon reset. That's not working. You can see it work with our AT pass through code found here: ftp://ftp.multitech.com/wireless/MTQ/

bridadan

Quite a nice solution! I have a few questions/suggestions below.

features/lwipstack/mbed_lib.json

bridadan · 2019-05-01T14:58:01Z

tools/toolchains/mbed_toolchain.py

+        if hasattr(self.target, 'post_binary_hook'):
+            if self.target.post_binary_hook is None:
+                define_string = self.make_ld_define(
+                    "DISABLE_POST_BINARY_HOOK", 1)


Really neat idea. I want to run a slight tweak by you and see what you think.

Naming the macro DISABLE_POST_BINARY_HOOK implies that a post binary hook is usually enabled. In general, this isn't the case, only a few targets use post binary hooks. How do you feel about changing this to macro to POST_BINARY_HOOK_ENABLED? So that would mean if post_binary_hook is not null, POST_BINARY_HOOK_ENABLED would be set to 1, otherwise it'd be set to 0?

I think this tweak makes the solution a bit more generic and potentially useful for other targets.

The reason I named it "DISABLE_POST_BINARY_HOOK" is because for those targets that have post_binary_hook, they're actually enabled in target.json. When you override it with null (uncommon case), it's becoming a "disable". I think you might come from a different perspective where most targets do not have post_binary_hook, yes?

linlingao · 2019-05-01T15:23:17Z

@felser I didn't change your bootloader. Mbed bootloader is not checked in so there's no way to include it. I'm not aware of any other bootloaders. Is it possible the MTS bootloader in the repo is out of date?

linlingao · 2019-05-01T15:26:55Z

@bridadan WRT the stack size, I knew I could override it in mbed_app.json. I did it on purpose since the stack size was okay prior to 5.12.2(?) release, but in the latest code, it's no longer enough. I would expect this issue to show up in all applications.

felser · 2019-05-01T16:49:10Z

Sorry, not sure what I did. Must have been "operator error"... our bootloader is working.

felser

Approving the PR. Bootloader is working as expected with default settings.

0xc0170

Target override for lwip in targets.json file for specific target to be set

… behalf of Ben C.

…NFLY_F411RE

…sabled by setting it to null

linlingao · 2019-05-02T16:45:50Z

I have reluctantly increased the tcpip stack just for this board. I think it would be a more proactive approach to increase the stack size for all boards so that we don't have to fix this same issue again and again. Our users tend to panic when they see a fault. Not everyone feels comfortable to go in and override the settings. Oh well, enough said.

0xc0170 · 2019-05-03T09:21:36Z

I have reluctantly increased the tcpip stack just for this board. I think it would be a more proactive approach to increase the stack size for all boards so that we don't have to fix this same issue again and again. Our users tend to panic when they see a fault. Not everyone feels comfortable to go in and override the settings. Oh well, enough said.

@SeppoTakalo Please review the feedback

0xc0170

One last question about DISABLE binary hook macro:

@bridadan proposed to have POST_BINARY_HOOK_ENABLED - wouldnt it be better ? set to 0 if not enabled, 1 if enabled. The linker scripts here would use this value.

bridadan

After going over it with @linlingao, she made a good argument that this is a lower touch change. My suggestion would add a new macro to every linker script. Generally I don't like the negative macro names (DISABLE_X) with positive values (1). But in this case I think its probably fine.

linlingao · 2019-05-06T15:22:11Z

@0xc0170 Is there work needed from my side? Can we merge this PR?

0xc0170 · 2019-05-10T07:49:36Z

CI started

mbed-ci · 2019-05-10T11:50:15Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

adbridge · 2019-05-10T12:10:33Z

Restarted exporters

linlingao changed the title ~~Correct NVIC flash vector address for application~~ Correct NVIC flash vector address for application - DO NOT MERGE YET Apr 1, 2019

ciarmcom requested review from a team April 1, 2019 21:00

ciarmcom added the needs: review label Apr 1, 2019

0xc0170 added needs: work and removed needs: review labels Apr 2, 2019

0xc0170 added the needs: preceding PR label Apr 4, 2019

cmonr removed the needs: preceding PR label Apr 8, 2019

linlingao changed the title ~~Correct NVIC flash vector address for application - DO NOT MERGE YET~~ Correct NVIC flash vector address for application Apr 11, 2019

linlingao added needs: review and removed needs: work labels Apr 11, 2019

0xc0170 reviewed Apr 12, 2019

View reviewed changes

targets/targets.json Show resolved Hide resolved

0xc0170 added needs: work and removed needs: review labels Apr 12, 2019

cmonr added the do not merge label Apr 12, 2019

linlingao force-pushed the pr10177 branch from 849b05a to de260bb Compare April 15, 2019 19:58

cmonr added needs: review and removed needs: work labels Apr 16, 2019

bridadan reviewed May 1, 2019

View reviewed changes

felser approved these changes May 1, 2019

View reviewed changes

0xc0170 requested changes May 2, 2019

View reviewed changes

Ben Cooke and others added 3 commits May 2, 2019 11:25

Correct the default pins for the spi flash for the mts dragonfly - on…

3d68a53

… behalf of Ben C.

Fix handoff issue from the bootloader to the application on MTS_DRAGO…

438a52f

…NFLY_F411RE

Add option to keep post_binary_hook and make it default. It can be di…

2c22f54

…sabled by setting it to null

linlingao force-pushed the pr10177 branch from ffb3d8a to 6ac9417 Compare May 2, 2019 16:28

Increase tcpip thread size for MTS_DRAGONFLY_F411RE

84b8517

linlingao force-pushed the pr10177 branch from 4976e67 to 84b8517 Compare May 2, 2019 16:35

linlingao requested a review from 0xc0170 May 2, 2019 16:38

0xc0170 reviewed May 3, 2019

View reviewed changes

bridadan approved these changes May 3, 2019

View reviewed changes

0xc0170 approved these changes May 10, 2019

View reviewed changes

0xc0170 added needs: CI release-version: 5.12.4 and removed needs: work labels May 10, 2019

adbridge added ready for merge and removed needs: CI labels May 10, 2019

adbridge merged commit 97e1c9c into ARMmbed:master May 10, 2019

adbridge removed the ready for merge label May 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable MTS_DRAGONFLY_F411RE to register with Pelion #10287

Enable MTS_DRAGONFLY_F411RE to register with Pelion #10287

linlingao commented Apr 1, 2019 •

edited

Loading

ciarmcom commented Apr 1, 2019

0xc0170 commented Apr 4, 2019

linlingao commented Apr 4, 2019

0xc0170 commented Apr 4, 2019

linlingao commented Apr 4, 2019

cmonr commented Apr 8, 2019

linlingao commented Apr 8, 2019

linlingao commented Apr 11, 2019

cmonr commented Apr 11, 2019

0xc0170 left a comment

linlingao commented Apr 12, 2019

0xc0170 commented Apr 12, 2019

linlingao commented Apr 15, 2019

felser commented May 1, 2019

bridadan left a comment

bridadan May 1, 2019

linlingao May 1, 2019

linlingao commented May 1, 2019

linlingao commented May 1, 2019

felser commented May 1, 2019

felser left a comment

0xc0170 left a comment

linlingao commented May 2, 2019

0xc0170 commented May 3, 2019

0xc0170 left a comment

bridadan left a comment

linlingao commented May 6, 2019

0xc0170 commented May 10, 2019

mbed-ci commented May 10, 2019

adbridge commented May 10, 2019

Enable MTS_DRAGONFLY_F411RE to register with Pelion #10287

Enable MTS_DRAGONFLY_F411RE to register with Pelion #10287

Conversation

linlingao commented Apr 1, 2019 • edited Loading

Description

Pull request type

Reviewers

Release Notes

ciarmcom commented Apr 1, 2019

0xc0170 commented Apr 4, 2019

linlingao commented Apr 4, 2019

0xc0170 commented Apr 4, 2019

linlingao commented Apr 4, 2019

cmonr commented Apr 8, 2019

linlingao commented Apr 8, 2019

linlingao commented Apr 11, 2019

cmonr commented Apr 11, 2019

0xc0170 left a comment

Choose a reason for hiding this comment

linlingao commented Apr 12, 2019

0xc0170 commented Apr 12, 2019

linlingao commented Apr 15, 2019

felser commented May 1, 2019

bridadan left a comment

Choose a reason for hiding this comment

bridadan May 1, 2019

Choose a reason for hiding this comment

linlingao May 1, 2019

Choose a reason for hiding this comment

linlingao commented May 1, 2019

linlingao commented May 1, 2019

felser commented May 1, 2019

felser left a comment

Choose a reason for hiding this comment

0xc0170 left a comment

Choose a reason for hiding this comment

linlingao commented May 2, 2019

0xc0170 commented May 3, 2019

0xc0170 left a comment

Choose a reason for hiding this comment

bridadan left a comment

Choose a reason for hiding this comment

linlingao commented May 6, 2019

0xc0170 commented May 10, 2019

mbed-ci commented May 10, 2019

Test run: FAILED

adbridge commented May 10, 2019

linlingao commented Apr 1, 2019 •

edited

Loading