SPI: Prime asynch transaction buffer on construction #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPI peripherals' asynch transaction buffers are now wrapped by SingletonPtr, which needs to take the singleton_lock Mutex when first accessed. If it was first accessed by an asynch transaction started from IRQ, that would not be possible. Add a SingletonPtr::get() call to the SPI construction process so that the peripheral's buffer is fully constructed before any SPI methods can be called, meaning asynch methods won't fail from IRQ. (Other pre-existing synchronisation issues with async remain, but this avoids a new trap in Mbed OS 5.12).
stevew817
approved these changes
Apr 25, 2019
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
Apr 29, 2019
|
Ci started |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
Ci restarted |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
CI was restarted, now all green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SPI peripherals' asynch transaction buffers are now wrapped by
SingletonPtr, which needs to take the singleton_lockMutexwhen first accessed. If it was first accessed by an asynch transaction started from IRQ, that would not be possible.Add a
SingletonPtr::get()call to theSPIconstruction process so that the peripheral's buffer is fully constructed before anySPImethods can be called, meaning asynch methods won't fail from IRQ.(Other pre-existing synchronisation issues with async remain, but this avoids a new trap in Mbed OS 5.12).
Pull request type
Reviewers
@stevew817