PSOC6: move mbed_sdk_init to mbed_overrides.c #10483
Conversation
Purposes:
* Remove MbedOS-specific code from system_psoc6_{cm4,cm0plus}.c
to simplify updates to new PDL version (startup code is part of PDL).
* Unify mbed_sdk_init initialization sequence for both CPU cores.
This change is non-functional, sequence itself is not changed for any
of the PSoC 6 M4/M0 PSA/non-PSA targets.
|
@vmedcy, thank you for your changes. |
| { | ||
| #if !defined(COMPONENT_SPM_MAILBOX) | ||
| /* Disable global interrupts */ | ||
| __disable_irq(); |
There was a problem hiding this comment.
you should use rather critical section here
There was a problem hiding this comment.
As this was in the code previously, we could still fix it here.
There was a problem hiding this comment.
This is now fixed by 737c98f - after further analysis, I can confirm entering critical section is not needed at all, init_cycfg_all is fine to execute with global interrupts enabled. I checked this functionally on CM4/CM0P PSA/non-PSA targets (actually there is no change in PSA case). On CM0+, global interrupts are enabled by ROM boot before Reset_Handler.
|
@0xc0170: code review feedback is addressed, the needless |
| init_cycfg_all(); | ||
|
|
||
| /* Enable global interrupts (disabled in CM4 startup assembly) */ | ||
| __enable_irq(); |
There was a problem hiding this comment.
is this still needed ? Previously was disable-enable pair, now only enable in sdk_init
There was a problem hiding this comment.
Yes. As mentioned in the code comment, CM4 startup assembly masks the global interrupts in Reset_Handler (this behavior is required to enable correct startup sequence under all scenarios, the code is there since the initial PDL 3.0.0 release).
For example, see startup_psoc6_01_cm4.S:
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Purposes:
to simplify updates to new PDL version (startup code is part of PDL).
This change is non-functional, sequence itself is not changed for any
of the PSoC 6 M4/M0 PSA/non-PSA targets.
Description
Pull request type
Reviewers
Release Notes