Removing support of FLASHIAP in general_filesystem tests #10523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed as skip anyway
|
@yossi2le, thank you for your changes. |
0xc0170
approved these changes
May 2, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
Test restarted (the failures were for not related changes and accross all devices, looks like CI error rather). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even so, FlashIAP block device was supported in the general_filesystem test, it was actually skipped. However, the static initialization of the filesystem cause problems in some cases and fail.
Because there is no logic of having all tests skipped and also there are only rare cases which justify supporting of a functional filesystem in an internal flash, I have removed all support of FLASHIAP from the test.
This solve issue #10264
Pull request type
Reviewers
Release Notes