Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix CCC callback not being called when writing to a CCC #10575

Merged
merged 2 commits into from
May 15, 2019

Conversation

paul-szczepanek-arm
Copy link
Member

Description

When creating a CCC manually the special handling of the attribute creation for CCC would set the correct CCC flag but then normal handling would also include the normal handling causing the setting for writable enabling the write callback which takes precedence. This fix removes that callback thus allowing the CCC callback to happen.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@paul-szczepanek-arm
Copy link
Member Author

@cy-kishore please comment

@ciarmcom ciarmcom requested review from a team May 14, 2019 11:00
@ciarmcom
Copy link
Member

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cy-kishore
Copy link

Hi,
After this fix, for explicit ccc descriptor when a client does read or write to cccd which application callback gets called? will onUpdatesEnabled and onUpdatesDisabled callbacks get called?

@0xc0170 0xc0170 requested a review from a team May 15, 2019 08:21
@cy-kishore
Copy link

Hi,
We have verified our use case with this fix and it is working. Please merge the same.

@mbed-ci
Copy link

mbed-ci commented May 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants