Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: fix Quectel BG96 missing unlock at socket_connect #10579

Merged
merged 2 commits into from
May 16, 2019
Merged

Cellular: fix Quectel BG96 missing unlock at socket_connect #10579

merged 2 commits into from
May 16, 2019

Conversation

kevinong0108
Copy link
Contributor

@kevinong0108 kevinong0108 commented May 14, 2019 •
edited
Loading

Description

Cellular Quectel BG96 missing call _at.unlock() before return error, it may cause deadlock.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica @jarvte

Release Notes

@ciarmcom ciarmcom requested review from jarvte, mirelachirica and a team May 14, 2019 15:01
@ciarmcom
Copy link
Member

@kevinong0108, thank you for your changes.
@mirelachirica @jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

jarvte
jarvte approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@jarvte jarvte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@0xc0170
Copy link
Contributor

0xc0170 commented May 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 6344b9d into ARMmbed:master May 16, 2019
@kevinong0108 kevinong0108 deleted the fix_cellular_quectel_bg96 branch May 23, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarvte jarvte jarvte approved these changes

@kivaisan kivaisan kivaisan approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kevinong0108 @ciarmcom @0xc0170 @mbed-ci @mirelachirica @kivaisan @jarvte @adbridge