Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MBED_ASSERT for UTs #11132

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Fix MBED_ASSERT for UTs #11132

merged 1 commit into from
Aug 1, 2019

Conversation

kivaisan
Copy link
Contributor

Description

For UTs mbed_assert_internal should not be declared as MBED_NORETURN
as UT stub for mbed_assert_internal only prints out the assert trace
and returns back to original code.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Fix MBED_ASSERT for UTs
882c21b 
For UTs mbed_assert_internal should not be declared as MBED_NORETURN
as UT stub for mbed_assert_internal only prints out the assert trace
and returns back to original code.
@ciarmcom ciarmcom requested a review from a team July 31, 2019 13:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@kivaisan kivaisan mentioned this pull request Aug 1, 2019
Closed
@SeppoTakalo SeppoTakalo merged commit 6722d8c into ARMmbed:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kivaisan @ciarmcom @SeppoTakalo