TLSSocketWrapper::recvfrom sets SocketAddress output variable

[dmaziec]

Description

According to: #10865 . In TLSSocketWrapper::recvfrom outputs SocketAddress the peer address. It is tested by UNITTEST. TLSSocketWrapper unittest does not use stoip4_stub anymore.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@michalpasztamobica
@kjbracey-arm

[ciarmcom]

@dmaziec1, thank you for your changes.
@SeppoTakalo @kjbracey-arm @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

[SeppoTakalo]

Fix looks OK, but I would prefer not to copy the stoip4() into the stub folder.
If we require the original code in this case, we should include it in the test.

[SeppoTakalo]

Instead of copying the stoip4() function here, can we modify the build scripts to include the original code.

Maintaining a stub and original, which both are identical, does not make sense.

[michalpasztamobica]

It is not exactly the original. It never returns false and doesn't even perform all the checks, so it can be safely used in other tests, which don't really care about the data being copied or not, and would do fine with an empty stub.
However, to check that the getpeername works we need to perform the copy in this one place - hence the copying algorithm runs if the inputs are valid.
If we were to use the actual function we would have to guarantee the input parameters validity. Should we?

[SeppoTakalo]

If I remove the usage of this stub from TLSSocket tests, it passes OK.

$ git diff
diff --git i/UNITTESTS/features/netsocket/TLSSocketWrapper/unittest.cmake w/UNITTESTS/features/netsocket/TLSSocketWrapper/unittest.cmake
index 2ff13c2dc6..d126328baf 100644
--- i/UNITTESTS/features/netsocket/TLSSocketWrapper/unittest.cmake
+++ w/UNITTESTS/features/netsocket/TLSSocketWrapper/unittest.cmake
@@ -28,8 +28,6 @@ set(unittest-test-sources
   stubs/mbed_shared_queues_stub.cpp
   stubs/nsapi_dns_stub.cpp
   stubs/EventFlags_stub.cpp
-  stubs/stoip4_stub.c
-  stubs/ip4tos_stub.c
   stubs/SocketStats_Stub.cpp
 )

Notice that UNITTESTS/features/netsocket/TLSSocketWrapper/unittest.cmake already seem to include the original stoip4()

I does not seem to require getpeername(), that is tested elsewhere.

[dmaziec]

Thanks, good point. We haven't tried it before, but it works.

[michalpasztamobica]

@0xc0170 , I cannot rerun the failed job, but I believe if you do, we will be able to merge this, as it's reviewed and approved.
Unless, @kjbracey-arm , would like to have a final word, as the original author of the issue report? :)

[0xc0170]

CI started

[0xc0170]

continuous-integration/jenkins/pr-merge

Should be fixed as well :)

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts