-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FATFileSystem::stat() enabled for all compilers #11193
Conversation
Macro which restricted compilation to GCC_ARM is removed. Existing read_write() test is amended to call stat() and check that correct size is returned.
@michalpasztamobica, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if this breaks ARMC5? You might want to have a #ifndef __CC_ARM
there for that.
Despite lack of official support or testing, if it's easy to avoid breakage, we should.
@kjbracey-arm , I checked that the proposed changes compile fine with:
and the test (as modified in this review) passed. |
Cool. I wonder why it was originally thought not to work on ARMCC then? |
To my understanding the reasons were twofold: 1) not enough testing to be sure that this worked 2) even if the testing was there and indicated an issue a couple of years ago, then both IAR and ARM compiler improved since then - the |
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Fixes #10198
Macro which restricted compilation to GCC_ARM is removed.
Existing read_write() test is amended to call stat() and check that correct size is returned.
Pull request type
Reviewers
@SeppoTakalo
@geky
@kjbracey-arm