Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcc.py for preprocessing in linker script #11254

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Conversation

jh228
Copy link
Contributor

@jh228 jh228 commented Aug 19, 2019

To fix #11214, we need this update. :-)

Description

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team August 19, 2019 01:00
@ciarmcom
Copy link
Member

@jh228, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

Is it only GCC , the other toolchains do not need any fix?

I can't recall if there was a reason for not having this in. We preprocess linker script (how bootloader gets in or out via start/end address). Is this just fixing adding some symbols rather than adding preprocessing?

@andrewc-arm
Copy link
Contributor

Hi, @0xc0170
Can we put enabling Arm Keil and IAR toolchain enablement as a separate Arm internal JIRA ticket? I think it would be polite to let our customer's need to be CI tested and PR approved as it is and someone else with good understanding of Keil and IAR Python scripts to follow your concern. 😃

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

Yes, can be treated separately just trying to understand the scope of this - if it is generic issue or toolchain specific - what we have missed. This review should help us understand if we missed one toolchain or it's generic and ask the question - was there an intention of keeping this away?

cc @ARMmbed/mbed-os-tools

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2019

I reviewed other exporters, they do not export config symbols neither. This means there was an intention perhaps. I could not locate any more information for this neither an issue besides the one mentioned above. @ARMmbed/mbed-os-tools Your review needed.

One thing that comes to my mind is extending the cmd by adding config symbols to the ld.

@andrewc-arm
Copy link
Contributor

Hi, @ARMmbed/mbed-os-tools
Any update? 😁

@mark-edgeworth
Copy link
Contributor

mark-edgeworth commented Sep 10, 2019

Hi, @ARMmbed/mbed-os-tools
Any update? 😁

I'm sorry but I don't know enough about this to be able to approve or otherwise.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2019

@mark-edgeworth Can you catch up with Jimmy ? he might know a reason why was not there.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2019

I'll run CI meanwhile

@theotherjimmy
Copy link
Contributor

@0xc0170 This is not an exporter, so discussion about exporters is not relevant. The other compilers build preprocessing into their linker in some fashion, and make this change unnecessary to IAR and ARMC5/6.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like this is fine.

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewc-arm
Copy link
Contributor

Awesome. Thank you for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocessing of linker script does not include macro definitions
7 participants