FATFS / IAR compilation issue Pe029 #11259
Conversation
ciarmcom
requested review from
0xc0170,
kjbracey,
michalpasztamobica and
a team
|
@JanneKiiskila, thank you for your changes. |
There was a problem hiding this comment.
I'm not actually sure why IAR is rejecting this. Seems like it should be legal to me (after 20 minutes of staring at cppreference).
But it's crummy code anyway, and the memset is worse.
Instead, please get rid of the assignment in the body, and just add _fs() to the member initialiser list. That will clear it out nicely.
|
BTW, which version of IAR are you using, and why isn't this showing up in some CI? |
It's 2019 now.
IAR compilation fails at `_fs = { 0 };` due to
```
[Error] FATFileSystem.cpp@285,0: [Pe029]: expected an expression
```
Changing that object initializer list instead, as that seems
to pass IAR compilation, too.
Changed original memset to object initialiser list based on review
feedback from Kevin Bracey.
JanneKiiskila
force-pushed
the
fatfs-iar
branch
from
84cf24f to
f149b4c
Compare
|
This is actually showing up on Client CI, hence the PR. Rebased, force pushed and changed the memset to initializer list implementation as per your feedback (very valid one). |
|
Fully agree on that. |
|
Seems different IAR versions behave differently here, IAR 8.32 seems to compile even w/o this fix, but an older one - fails. |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Then I reckon it was a now-fixed compiler bug. The code seemed valid. |
IAR / FATFS - Pe029 error
IAR compilation fails at
_fs = { 0 };due toChanging that initializer fixes the issue. IAR is more sensitive
in C/C++ being mixed together than other compilers.
Reviewers
@0xc0170 @kjbracey-arm @michalpasztamobica