Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in USBSerial.h function prevents compilation #11260

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Typo in USBSerial.h function prevents compilation #11260

merged 1 commit into from
Aug 22, 2019

Conversation

rvasquez6089
Copy link

Description

In one of attach function calls in the USBSerial class, the object pointer is flipped with the location of the static location of the function. This prevents code from compiling when using the the attach function properly. Just a small typo that needed fixing.

rx = mbed::Callback<void()>(mptr, tptr); <--- Incorrect

rx = mbed::Callback<void()>(tptr, mptr); <----Correct
to match this function prototype ---> Callback(U *obj, R(T::*method)())

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team August 19, 2019 19:00
@ciarmcom
Copy link
Member

@rvasquez6089, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

cc @mbed-os-test - also this one - client test failing

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

cc @mbed-os-test - also this one - client test failing

Known issue, will be restarted once fixed

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@adbridge
Copy link
Contributor

restarted

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@bulislaw
Copy link
Member

How is that tested that we didn't catch this issue? @jamesbeyond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants