-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in USBSerial.h function prevents compilation #11260
Conversation
@rvasquez6089, thank you for your changes. |
CI started |
CI restarted |
cc @mbed-os-test - also this one - client test failing |
Known issue, will be restarted once fixed |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
How is that tested that we didn't catch this issue? @jamesbeyond |
Description
In one of attach function calls in the USBSerial class, the object pointer is flipped with the location of the static location of the function. This prevents code from compiling when using the the attach function properly. Just a small typo that needed fixing.
rx = mbed::Callback<void()>(mptr, tptr);
<--- Incorrectrx = mbed::Callback<void()>(tptr, mptr);
<----Correctto match this function prototype --->
Callback(U *obj, R(T::*method)())
Pull request type
Reviewers
Release Notes