Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mbed-coap to version 4.8.1 #11270

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Update mbed-coap to version 4.8.1 #11270

merged 1 commit into from
Aug 22, 2019

Conversation

anttiylitokola
Copy link
Contributor

Description

  • Store ACK's also into duplicate info list.
  • ROM size optimization. Flash size has gone down ~1100 bytes.

Closed issues:

  • IOTCLT-3592 - Client does not handle Duplicate ACK messages during blockwise registration correctly

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yogpan01, @teetak01

@ciarmcom ciarmcom requested review from teetak01, yogpan01 and a team August 21, 2019 07:00
@ciarmcom
Copy link
Member

@anttiylitokola, thank you for your changes.
@yogpan01 @teetak01 @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

@ARMmbed/mbed-os-wan Unittest failure related to this change? [2019-08-21T07:30:17.067Z] 31: mbed assertation failed: obj.timer_id != 0, file: /builds/ws/mbed-os-ci_unittests/unitTest-3649/mbed-os/features/lorawan/system/LoRaWANTimer.cpp, line 57 , please check the logs

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@teetak01
Copy link
Contributor

flaky unittest? This PR cannot impact LoraWAN.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

@anttiylitokola I'll restart the tests, another thing is - is your branch up to date? As the failures are not related to the changeset

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

unittest green 💯 CI progressing

Update mbed-coap to version 4.8.1
7ba7f7e 
- Store ACK's also into duplicate info list.
- ROM size optimization. Flash size has gone down ~1100 bytes.

**Closed issues:**
-  IOTCLT-3592 - Client does not handle Duplicate ACK messages during blockwise registration correctly
@anttiylitokola anttiylitokola force-pushed the update-mbed-coap-to-4.8.1 branch from e8c634f to 7ba7f7e Compare August 21, 2019 10:08
@anttiylitokola
Copy link
Contributor Author

@anttiylitokola I'll restart the tests, another thing is - is your branch up to date? As the failures are not related to the changeset

True, my fork was outdated. Rebased and force pushed.

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

Restarted tests after rebase

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2019

cc @ARMmbed/mbed-os-test ^^ internal error in CI, few other jobs have the same one

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2019

Error resolved, all good here

@0xc0170 0xc0170 merged commit 6812869 into ARMmbed:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teetak01 teetak01 teetak01 approved these changes

@yogpan01 yogpan01 yogpan01 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anttiylitokola @ciarmcom @0xc0170 @mbed-ci @teetak01 @yogpan01