Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix BG96 power on and connect #11372

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Conversation

AriParkkila
Copy link

Description

Fixed BG96 power up/down, disconnect at shutdown(), and retry at cellular state-machine calling init() to make dis/connect more robust. Also some log prints changed to be more informative and less noisy.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica @jarvte

Release Notes

@ciarmcom ciarmcom requested review from jarvte, mirelachirica and a team August 29, 2019 13:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@mirelachirica @jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

@AriParkkila The latest merge caused a conflict, please rebase

@AriParkkila
Copy link
Author

@0xc0170 It's rebased now.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@AriParkkila
Copy link
Author

unittests are fixed now.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

CI restarted (internal fault)

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

@AriParkkila Can you rebase pls? There's conflict caused by earlier patch.

@AriParkkila
Copy link
Author

@0xc0170 This is rebased now.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2019

cloud client restarted (internal fault)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants