Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use very verbose to see more details in case of problem #11382

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Use very verbose to see more details in case of problem #11382

merged 1 commit into from
Sep 5, 2019

Conversation

OPpuolitaival
Copy link
Contributor

Description

'mbed compile -v' does not provide enough verbose to see problems. Adding '-vv' to see more details in logs.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

Wouldn't this cause an issue for CI (logs size, time to log all) ?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

I assume this is for testing purposes only ?

@ciarmcom ciarmcom requested review from a team August 30, 2019 07:00
@ciarmcom
Copy link
Member

@OPpuolitaival, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

CI restarted (example was broken, has to be refetched)

@adbridge
Copy link
Contributor

Wouldn't this cause an issue for CI (logs size, time to log all) ?

@OPpuolitaival I concur with Martin, this would be fine for a test but I don't think we want this in the options as the default? Potentially much bigger logs ?

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@OPpuolitaival
Copy link
Contributor Author

@adbridge I would like to get this merged. -v for build scripts do not provide much verbose. -vv only really tells something internal communication. This is also behind verbose flag in example.py and not used as default

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

No impact on build time and size of the logs - all fine there?

mark-edgeworth
mark-edgeworth approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me: since it only appears to affect test it should not have an impact on 'normal' building.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

Ci restarted, java exception

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

Because of 5.14.0-rc1 CI jobs, we aborted CI job here. We will restart once 5.14.0rc1 is ready.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 6
Build artifacts

@0xc0170 0xc0170 merged commit 5f4698f into ARMmbed:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@adbridge adbridge Awaiting requested review from adbridge

Assignees
No one assigned
Labels
release-version: 5.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OPpuolitaival @0xc0170 @ciarmcom @mbed-ci @adbridge @mark-edgeworth