-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: USB: Use libusb0 backend on Windows #11458
Tests: USB: Use libusb0 backend on Windows #11458
Conversation
libusb0 supports all features used for testing. A newer version (libusb1) does not have a complete implementation for Windows.
libusb0 supports all features used for testing. A newer version (libusb1) does not have a complete implementation for Windows.
@fkjagodzinski, thank you for your changes. |
@jamesbeyond Please review |
Hi I could start pyocd gdbserver, [1569231275.73][HTST][ERR] host test not detected: usb_device_serial |
@jeromecoutant If you use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @fkjagodzinski, what is the impact to the test setup? do we need to update anything the documentation related to the setup? |
@jamesbeyond, no impact on the setup procedure. This patch explicitly sets the pyusb backend to libusb0 to make sure we always use the driver set by Zadig. If the user has libusb1 present in Win environment, it will be loaded by default by pyusb. This is bad, since this lib version does not provide all features we use in tests. |
@jamesbeyond are you happy with this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy, good to go @adbridge
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
libusb0 supports all features used for testing. A newer version (libusb1) does not have a complete implementation for Windows.
Moreover, this will stop our USB device tests from using a
libusb-1.0.dll
which may have been copied to the Python directory by the user (i.e. following pyOCD installation procedure).Pull request type
Reviewers
@jeromecoutant, @jamesbeyond
Release Notes