Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tickless mode in additional tested targets #11480

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Enable tickless mode in additional tested targets #11480

merged 1 commit into from
Sep 23, 2019

Conversation

gpsimenos
Copy link
Contributor

@gpsimenos gpsimenos commented Sep 13, 2019 •
edited
Loading

Description

This PR is part of IOTCLOUDPR-3223. The requirement is to enable tickless mode in targets that CI can run tests on. In this PR, tickless mode is enabled in 3 targets that have preexisting minor greentea errors, and tickless mode has not caused additional errors:

  • NUCLEO_F401RE
  • NUCLEO_F411RE
  • UBLOX_EVK_ODIN_W2

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @hugueskamba

@gpsimenos gpsimenos changed the title Enable tickless mode on additional tested targets Enable tickless mode in additional tested targets Sep 13, 2019
@ciarmcom ciarmcom requested review from evedon, hugueskamba and a team September 13, 2019 11:00
@ciarmcom
Copy link
Member

@gpsimenos, thank you for your changes.
@hugueskamba @evedon @ARMmbed/mbed-os-maintainers please review.

jeromecoutant
jeromecoutant reviewed Sep 13, 2019
View reviewed changes
targets/targets.json Outdated
@@ -4367,7 +4367,8 @@
"STM32L475xx",
"MBED_TICKLESS",
"EXTRA_IDLE_STACK_REQUIRED",
"MBED_SPLIT_HEAP"
"MBED_SPLIT_HEAP",
"MBED_TICKLESS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macro already present...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macro removed

evedon
evedon requested changes Sep 13, 2019
View reviewed changes
targets/targets.json Outdated Show resolved Hide resolved
targets/targets.json Outdated Show resolved Hide resolved
targets/targets.json Outdated Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2019

There is a failure for one target "[Error] mbed_rtx_idle.cpp@46,2: Low power ticker required when MBED_CONF_TARGET_TICKLESS_FROM_US_TICKER is false", please review

@gpsimenos
Copy link
Contributor Author

This force push removes one failing target.

@evedon
Copy link
Contributor

evedon commented Sep 20, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Sep 23, 2019
@0xc0170 0xc0170 merged commit f513bce into ARMmbed:master Sep 23, 2019
@kimlep01 kimlep01 mentioned this pull request Sep 24, 2019
Closed
@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed release-version: 5.15.0-rc1 labels Oct 3, 2019
@gpsimenos gpsimenos mentioned this pull request Oct 3, 2019
Merged
@jeromecoutant
Copy link
Collaborator

Hi @gpsimenos

With that PR, TICKLESS has been introduced for NUCLEO_F401RE, NUCLEO_F411RE and UBLOX_EVK_ODIN_W2.

Already reverted for UBLOX_EVK_ODIN_W2 in #11625
Now, for F411RE, seems that SPI issue from #11682 is due to TICKLESS :-(

@LMESTM @ABOSTM @MarceloSalazar

@gpsimenos
Copy link
Contributor Author

Let's revert for F411RE too. Should I open the PR?

@jeromecoutant
Copy link
Collaborator

@ABOSTM is going to clean all configurations
Thx

@0xc0170 0xc0170 added release-version: 5.15.0-rc1 and removed release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant left review comments

@evedon evedon evedon approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba Awaiting requested review from hugueskamba

Assignees
No one assigned
Labels
release-version: 5.15.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gpsimenos @ciarmcom @0xc0170 @mbed-ci @evedon @jeromecoutant @adbridge