Improve cellular unittests #11495
Merged
Improve cellular unittests #11495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 17, 2019 10:45
Also added checks for pointer validity.
OPpuolitaival
approved these changes
Sep 17, 2019
added 5 commits
September 17, 2019 12:56
As shutdown was overridden in test class, original shutdown() method was not called at all.
|
Pushed fix for astyle failures. |
0xc0170
approved these changes
Sep 17, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
@0xc0170 Build failure does not seem to relate to this change. Some CI problem? |
|
@kivaisan you are right. Problem is not related to this |
|
CI restarted |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
CI restarted (again internal error) |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved UT test coverage of cellular components.
No functional changes to actual code except some pointer validity checks on some methods. Also clarifiied documentation of
CellularNetwork::is_active_contextmethod.Pull request type
Reviewers
@OPpuolitaival @AnttiKauppila
Release Notes