Tests: USB: Fix Python 3 compatibility #11546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madchutney
reviewed
Sep 23, 2019
|
@fkjagodzinski, thank you for your changes. |
OPpuolitaival
approved these changes
Sep 23, 2019
0xc0170
approved these changes
Sep 24, 2019
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
0xc0170
added
ready for merge
release-version: 5.14.1
needs: review
and removed
needs: CI
ready for merge
labels
|
@fkjagodzinski What shall we do with six, do you want to update it and use it here? |
added 2 commits
September 30, 2019 10:20
This version provides a few handy functions: six.ensure_binary, six.ensure_text, and six.ensure_str.
Use integer division explicitly in basic test. Convert bytes to str for Python 3 in serial test.
fkjagodzinski
force-pushed
the
test_update-usb-python3
branch
from
96581ff to
2b4b64f
Compare
|
I decided to update this patch to use the new version of |
|
@0xc0170, could you re-trigger the CI? Apart from that, do I need to add a release note, or notify anyone? |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
Hi |
|
OK... I just see the six version requirement... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #11520.
Use integer division explicitly in basic test.
Convert bytes to str for Python 3 in serial test.
After the update, this patch also bumps the version of
sixmodule to 1.12.0.Pull request type
Reviewers
@OPpuolitaival @madchutney
Release Notes