Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed_rtc_time.h lacks an include guard #11661

Merged
merged 1 commit into from
Oct 15, 2019
Merged

mbed_rtc_time.h lacks an include guard #11661

merged 1 commit into from
Oct 15, 2019

Conversation

Alex-EEE
Copy link
Contributor

@Alex-EEE Alex-EEE commented Oct 9, 2019 •
edited
Loading

Adds a missing include guard

Description

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team October 9, 2019 23:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 9, 2019

@Alex-EEE, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

hugueskamba
hugueskamba approved these changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2019

This is strange but Travis reports failure for events. I don't find it related however failed already 2x time with compilation error.

@Alex-EEE Can you reproduce it locally? There's command shown right after the error to test it locally

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2019

Scratch that, something was wrong with Travis, I restarted again to make sure the error is valid.

All good here

@0xc0170 0xc0170 merged commit 119e99f into ARMmbed:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Alex-EEE @ciarmcom @0xc0170 @mbed-ci @hugueskamba