Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with integer overflow when converting time units #11669

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fixed issue with integer overflow when converting time units #11669

merged 1 commit into from
Oct 15, 2019

Conversation

morser499
Copy link

Description

  • Fixed a potential integer overflow when converting from one time format to another.
  • Updated a comment to better describe what happens when null is provided.

Pull request type

[x] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from maclobdell and a team October 10, 2019 21:00
@ciarmcom
Copy link
Member

@morser499, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 89c08f5 into ARMmbed:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morser499 @ciarmcom @0xc0170 @mbed-ci @cy-opm