Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCU_NRF52840: Switches to correct Product Anomaly Notification(PAN) macro #11706

Merged
merged 1 commit into from
Oct 22, 2019
Merged

MCU_NRF52840: Switches to correct Product Anomaly Notification(PAN) macro #11706

merged 1 commit into from
Oct 22, 2019

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Oct 18, 2019 •
edited
Loading

Description

A wrongly named macro was used rendering available workaround for the NRF52840 MCU useless. The anomaly is shared between the two MCU revisions and all engineering samples.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnttiKauppila
@kivaisan
@0xc0170
@teetak01

Release Notes

@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@AnttiKauppila @teetak01 @0xc0170 @kivaisan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from teetak01 and a team October 18, 2019 05:00
@40Grit
Copy link

40Grit commented Oct 18, 2019

@trowbridgec, @farrenv, @AGlass0fMilk

@0Grit
Copy link

0Grit commented Oct 18, 2019

@maclobdell wondering if this is why EP_AGORA fails RTC tests

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019

@maclobdell wondering if this is why EP_AGORA fails RTC tests

Can we retest?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2019

Started CI meanwhile

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@40Grit
Copy link

40Grit commented Oct 22, 2019

Is this good to merge?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 22, 2019

I was waiting for requested reviewers to review , should be all good as change is simple.

@0xc0170 0xc0170 merged commit 97ef25f into ARMmbed:master Oct 22, 2019
@VeijoPesonen VeijoPesonen deleted the nrf52840_fix_product_anomaly_macro branch October 23, 2019 06:34
@VeijoPesonen VeijoPesonen mentioned this pull request Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila Awaiting requested review from AnttiKauppila

@kivaisan kivaisan Awaiting requested review from kivaisan

@teetak01 teetak01 Awaiting requested review from teetak01

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VeijoPesonen @ciarmcom @40Grit @0Grit @0xc0170 @mbed-ci