Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy process event first on connection complete #11718

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

desmond-blue
Copy link
Contributor

@desmond-blue desmond-blue commented Oct 21, 2019

Description

This is a proposed fix for mbed-os-example-ble issue 257.

SM control block doesn't get ready when calling user-defined on_connection_complete process event, so I move the legacy process event forward.

Tested with BLE_SM/BLE_GAP/BLE_Battery/BLE_GattServer on NRF52840_DK.

Updated:
This PR only fix Error during SM::setLinkSecurity 4.
To make BLE SM example work, onAdvertisingEnd() should care if the connection is established, like this mbed-os-example-ble#265 does.

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team October 21, 2019 11:00
@ciarmcom
Copy link
Member

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@AGlass0fMilk
Copy link
Member

This does not completely resolve ARMmbed/mbed-os-example-ble#257 when I build that example with this branch.

@desmond-blue
Copy link
Contributor Author

@AGlass0fMilk You are correct, I didn't state it well.
This PR only fix Error during SM::setLinkSecurity 4.
To make BLE SM example work, onAdvertisingEnd() should care if the connection is established, like this mbed-os-example-ble#265 does.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants