Ensure modem echo is off before sending other AT commands #11719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wajahat-ublox, thank you for your changes. |
|
@MarceloSalazar it has fixed random failure in cellular integration test introduced recently. Please update us if you want something to change ! Added @RobMeades |
AnttiKauppila
approved these changes
Nov 1, 2019
0xc0170
approved these changes
Nov 4, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently three AT commands are sent together and response for OK is checked only for last command. This means that there can be a case where modem echo remains on as it sent OK to AT+CFUN=1 command but did not receive first two commands (reason being not fully powered up yet).
This can affect the functionality of cellular APIs and test cases. It is better to first ensure that modem is responding to ATE0 command and then send other commands.
Pull request type
Reviewers
Release Notes