Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxp LPC55S69: fix i2c pin mapping #11734

Merged
merged 1 commit into from
Oct 24, 2019
Merged

nxp LPC55S69: fix i2c pin mapping #11734

merged 1 commit into from
Oct 24, 2019

Conversation

maciejbocianski
Copy link
Contributor

Description

Fix LPC55S69 I2C pin mapping on arduino A5/A4 pins

Target page also needs to be updated (https://os.mbed.com/platforms/LPCXpresso55S69/)

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond
@ARMmbed/team-nxp

Release Notes

@ciarmcom
Copy link
Member

@maciejbocianski, thank you for your changes.
@jamesbeyond @maclobdell @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from jamesbeyond, maclobdell and a team October 23, 2019 07:00
@0xc0170 0xc0170 requested a review from a team October 23, 2019 07:27
@mmahadevan108
Copy link
Contributor

Per the schematics P0_13 is I2C_SDA and P0_14 is I2C_SCL. I have tested the I2C with the FPGA sheid board and it passed the I2C test.

Board Schematics can be accessed from the below link:
https://www.nxp.com/products/processors-and-microcontrollers/arm-microcontrollers/general-purpose-mcus/lpc5500-cortex-m33/lpcxpresso55s69-development-board:LPC55S69-EVK

@maciejbocianski
Copy link
Contributor Author

@mmahadevan108
True, the fix should go here (

mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_LPCXpresso/PinNames.h

Lines 180 to 181 in 6240335

A4 = P0_14,
A5 = P0_13,
)

@mmahadevan108
Copy link
Contributor

@mmahadevan108
True, the fix should go here (

mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_LPCXpresso/PinNames.h

Lines 180 to 181 in 6240335

A4 = P0_14,
A5 = P0_13,

)

Thank you, I see the issue. Could you please help update the PR.

@maciejbocianski maciejbocianski force-pushed the nxp_lpc55s69_i2c_pinmap_fix branch from 18ffcc7 to bb91975 Compare October 23, 2019 17:49
@maciejbocianski
Copy link
Contributor Author

@mmahadevan108 done

mmahadevan108
mmahadevan108 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 58ef53a into ARMmbed:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@jamesbeyond jamesbeyond Awaiting requested review from jamesbeyond

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maciejbocianski @ciarmcom @mmahadevan108 @0xc0170 @mbed-ci