Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 QSPI: Use defines for setting address size #11759

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Oct 28, 2019

Description (required)

A small clean-up Pull Request, to align with rest of the code following recent changes in QSPI.

Summary of change (What the change is for and why)

The change follows recent updates and can be considered a cosmetic change but should be future proof for any new STM32 devices with QSPI.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

Tested fine on DISCO_L475VG_IOT01A

+-----------------------------+---------------------+---------------------+--------+--------------------+-------------+
| target                      | platform_name       | test suite          | result | elapsed_time (sec) | copy_method |
+-----------------------------+---------------------+---------------------+--------+--------------------+-------------+
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | OK     | 37.78              | default     |
+-----------------------------+---------------------+---------------------+--------+--------------------+-------------+
+-----------------------------+---------------------+---------------------------------------------------------+--------+--------------------+-------------+
| target                      | platform_name       | test suite                                              | result | elapsed_time (sec) | copy_method |
+-----------------------------+---------------------+---------------------------------------------------------+--------+--------------------+-------------+
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | features-storage-tests-blockdevice-general_block_device | OK     | 38.42              | default     |
+-----------------------------+---------------------+---------------------------------------------------------+--------+--------------------+-------------+
[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@jeromecoutant

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST CI OK also with DISCO_F769NI and DISCO_F746NG (other embedded QSPI memories)

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 73b4f71 into ARMmbed:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants