-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding set baud rate routine #11783
Adding set baud rate routine #11783
Conversation
@mirelachirica, thank you for your changes. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see also comments/questions.
features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp
Outdated
Show resolved
Hide resolved
features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp
Outdated
Show resolved
Hide resolved
_at->set_baud(baud_rate); | ||
|
||
// Give some time before starting using the UART with the new baud rate | ||
rtos::ThisThread::sleep_for(3000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could poll with an AT command to make it more responsive?
@@ -119,6 +120,15 @@ void rcv_n_chk_against_rfc864_pattern(TCPSocket &sock) | |||
void TCPSOCKET_RECV_100K() | |||
{ | |||
SKIP_IF_TCP_UNSUPPORTED(); | |||
|
|||
#ifdef MBED_CONF_APP_BAUD_RATE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be modem specific config?
391b042
to
fe5c12b
Compare
fe5c12b
to
3fdbe24
Compare
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description (required)
Added set baud rate routines for cellular devices.
Pull request type (required)
Test results (required)
Reviewers (optional)
@AriParkkila