-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Socket API functions return values. #11808
Conversation
b33f8f8
to
40df54a
Compare
I just realized that there were |
@michalpasztamobica Please rebase to resolve conflict |
40df54a
to
2429935
Compare
@0xc0170 , rebased and conflicts resolved. |
CI started |
Travis found one issue in doxygen: "authetication" - please fix |
Describe the return values with as much detail as possible, to let user only check the relevant return codes, instead of all nsapi_error_t. Refer to underlying APIs wherever possible.
2429935
to
87211e9
Compare
@0xc0170 , fixed :) |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
CI restarted (aborted above) |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
I don't think the failure is related:
@0xc0170 , I only changed Doxygen documentation. Does it make sense to run the whole CI? |
I restarted cloud test |
As these are small corrections to return values, I'll merge this today. @AnotherButler If any change requested , will be addressed separately. |
This contains changes on top of #11357 which is targeting 5.15 |
Description (required)
Improved the Doxygen documentation of Socket API return values with as much detail as possible, to let user only check the relevant return codes, instead of all nsapi_error_t. Refer to underlying APIs wherever possible.
Once this PR gets reviewed we would like to perform a similar excercise on other APIs. Relevant work item will be created in internal JIRA.
Summary of change (What the change is for and why)
Help API users only check the relevant error codes. Prepare for module tests, which would verify the possible error scenarios, protecting the API from unexpected changes and helping us identify "breaking changes".
Documentation (Details of any document updates required)
This is in fact a documentation update only.
Pull request type (required)
Test results (required)
Reviewers (optional)
@AnttiKauppila
@tymoteuszblochmobica
@mtomczykmobica