Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOTBTOOL-333: Fix SimpleQueue build failure on py3 #11823

Merged
merged 1 commit into from
Nov 7, 2019
Merged

IOTBTOOL-333: Fix SimpleQueue build failure on py3 #11823

merged 1 commit into from
Nov 7, 2019

Conversation

mark-edgeworth
Copy link
Contributor

Description (required)

The build system was using an internal feature of the Pool class that is unavailable
in a py3 system. This would cause an exception if tool execution failed.
Offending code has now been removed and tested on py3; error is no longer produced.

Summary of change (What the change is for and why)

See above

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

Build system was using an internal feature of the Pool class that is unavailable
in a py3 system. This would cause an exception if tool execution failed.
Offending code has now been removed
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making sure, even using internal function - by removing - we do not loose anything, it was not needed?

@mark-edgeworth
Copy link
Contributor Author

just making sure, even using internal function - by removing - we do not loose anything, it was not needed?

As far as I can tell this code is not required. The documentation on the following terminate() call says that all sub processes will be removed, so there should be no need to do this explicitly. Unfortunately there is no information on why the original change was added back in 2016.
Note that this only actually happens if the toolchain has failed to build the solution (ie it is in a failed state already).

@0xc0170 0xc0170 requested a review from a team November 6, 2019 14:59
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 7, 2019

@mark-edgeworth needed anyone else from @ARMmbed/mbed-os-tools to review? otherwise this is ready

@0xc0170 0xc0170 merged commit 0d26be4 into ARMmbed:master Nov 7, 2019
@mark-edgeworth mark-edgeworth deleted the fix-simplequeue branch November 11, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants